-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact acquisition: build profiles (optionally exclude datasources from final binary) #3217
Conversation
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3217 +/- ##
==========================================
+ Coverage 51.25% 51.27% +0.01%
==========================================
Files 340 355 +15
Lines 38771 38823 +52
==========================================
+ Hits 19873 19905 +32
- Misses 16942 16953 +11
- Partials 1956 1965 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0fc6fb1
to
22eb098
Compare
Just to ask a question instead of determining Yes, its an edge case which they can patch there own Makefile but 🤷🏻 |
I'm rewriting that part. |
@LaurenceJJones better now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
If we merge this, I'll remove "EXCLUDE_MEDIUM", it was just an example. |
bd7cb4f
to
8786bc6
Compare
f121f8c
to
6fa131b
Compare
example $ make BUILD_PROFILE=minimal or $ make EXCLUDE=datasource_s3,datasource_kinesis
6fa131b
to
7a14b63
Compare
No description provided.